Quote table name with backticks to escape special characters in spark.read.table() #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
requested review from
dai-chen,
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Could you check if this also needs change: https://github.com/opensearch-project/opensearch-spark/blob/main/flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSpark.scala#L375C28-L375C28
|
Missed that one.. added the change. |
Signed-off-by: Sean Kao <seankao@amazon.com>
No problem. Should be fine if all existing IT can pass. Thanks! |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.1 0.1
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.1
# Create a new branch
git switch --create backport/backport-224-to-0.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e163e77a2d8598ad105835f3ce20677d84fea84
# Push it to GitHub
git push --set-upstream origin backport/backport-224-to-0.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.1Then, create a pull request where the |
seankao-az
added a commit
to seankao-az/opensearch-spark
that referenced
this pull request
Jan 12, 2024
….read.table() (opensearch-project#224) * quote table name for special character in df read Signed-off-by: Sean Kao <seankao@amazon.com> * add UT Signed-off-by: Sean Kao <seankao@amazon.com> * update comments; scalafmtAll Signed-off-by: Sean Kao <seankao@amazon.com> * add a missed table name to quote Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 6e163e7)
seankao-az
added a commit
to seankao-az/opensearch-spark
that referenced
this pull request
Jan 12, 2024
….read.table() (opensearch-project#224) * quote table name for special character in df read Signed-off-by: Sean Kao <seankao@amazon.com> * add UT Signed-off-by: Sean Kao <seankao@amazon.com> * update comments; scalafmtAll Signed-off-by: Sean Kao <seankao@amazon.com> * add a missed table name to quote Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 6e163e7)
dai-chen
pushed a commit
that referenced
this pull request
Jan 12, 2024
….read.table() (#224) (#225) * quote table name for special character in df read Signed-off-by: Sean Kao <seankao@amazon.com> * add UT Signed-off-by: Sean Kao <seankao@amazon.com> * update comments; scalafmtAll Signed-off-by: Sean Kao <seankao@amazon.com> * add a missed table name to quote Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 6e163e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quote table name with backticks to escape special characters in spark.read.table()
Follow up on
which allows for creating flint index on table name with special characters, but build() on these index fails if table name not escaped by backticks (
`)Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.